Add Chronicle agent builtin sidecar definitions to Connect and Workbench#671
Merged
bschwedler merged 50 commits intomainfrom May 27, 2025
Merged
Add Chronicle agent builtin sidecar definitions to Connect and Workbench#671bschwedler merged 50 commits intomainfrom
bschwedler merged 50 commits intomainfrom
Conversation
t-margheim
reviewed
May 15, 2025
markrtucker
reviewed
May 16, 2025
ianpittwood
force-pushed
the
chronicle/product-side-car
branch
2 times, most recently
from
2e680a1 to
f749868
Compare
t-margheim
reviewed
May 20, 2025
bschwedler
requested review from
a team,
GCRev,
aronatkins,
christierney,
dbkegley,
matt-urbina,
zachhannum and
zackverham
as code owners
bschwedler
force-pushed
the
chronicle/product-side-car
branch
2 times, most recently
from
37acba4 to
72a4a35
Compare
… non-root and unprivileged execution
…ENVIRONMENT` if it is defined
bdeitte
reviewed
May 26, 2025
bdeitte
reviewed
May 26, 2025
bdeitte
reviewed
May 26, 2025
bdeitte
reviewed
May 26, 2025
Member
|
One nitpick of a suggestion, but this looks great (and great doc updates). I didn't even think about the agent as part of this. |
Co-authored-by: Benjamin R. J. Schwedler <bschwedler@gmail.com>
Co-authored-by: Benjamin R. J. Schwedler <bschwedler@gmail.com>
bschwedler
approved these changes
May 27, 2025
Comment on lines
+122
to
+125
| {{- with .Values.chronicleAgent.agentEnvironment }} | ||
| - name: CHRONICLE_AGENT_ENVIRONMENT | ||
| value: {{ . | quote }} | ||
| {{- end }} |
Contributor
There was a problem hiding this comment.
Thank you for setting this using an environment variable!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
initContainersdefinition for Chronicle agent to Workbench and Connect charts.rstudio-libraryto 0.1.32 in Workbench and Connect dependencies.